sarsoo/Spotify.NET
1
0
Fork 0
mirror of https://github.com/Sarsoo/Spotify.NET.git synced 2024-12-23 22:56:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential race condition inside RequestParams (#571)

Browse Source
This commit is contained in:
Jonas Dellinger 2021-03-03 09:36:46 +01:00 committed by GitHub
parent 81245b2339
commit aab8c5ddcb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
SpotifyAPI.Web/Models/Request/RequestParams.cs
View File

@ -34,16 +34,17 @@ namespace SpotifyAPI.Web
.GetProperties(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Public) .GetProperties(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Public)
.Where(prop => prop.GetCustomAttributes(typeof(BodyParamAttribute), true).Length > 0); .Where(prop => prop.GetCustomAttributes(typeof(BodyParamAttribute), true).Length > 0);
_bodyParamsCache[type] = new List<(PropertyInfo, BodyParamAttribute)>(); var cachedParams = new List<(PropertyInfo, BodyParamAttribute)>();
foreach (var prop in bodyProps) foreach (var prop in bodyProps)
{ {
var attribute = prop.GetCustomAttribute<BodyParamAttribute>(); var attribute = prop.GetCustomAttribute<BodyParamAttribute>();
if (attribute != null) if (attribute != null)
{ {
_bodyParamsCache[type].Add((prop, attribute)); cachedParams.Add((prop, attribute));
AddBodyParam(body, prop, attribute); AddBodyParam(body, prop, attribute);
} }
} }
_bodyParamsCache[type] = cachedParams;
} }
return body; return body;
@ -81,16 +82,17 @@ namespace SpotifyAPI.Web
var queryProps = GetType().GetProperties(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Public) var queryProps = GetType().GetProperties(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Public)
.Where(prop => prop.GetCustomAttributes(typeof(QueryParamAttribute), true).Length > 0); .Where(prop => prop.GetCustomAttributes(typeof(QueryParamAttribute), true).Length > 0);
_queryParamsCache[type] = new List<(PropertyInfo, QueryParamAttribute)>(); var cachedParams = new List<(PropertyInfo, QueryParamAttribute)>();
foreach (var prop in queryProps) foreach (var prop in queryProps)
{ {
var attribute = prop.GetCustomAttribute<QueryParamAttribute>(); var attribute = prop.GetCustomAttribute<QueryParamAttribute>();
if (attribute != null) if (attribute != null)
{ {
_queryParamsCache[type].Add((prop, attribute)); cachedParams.Add((prop, attribute));
AddQueryParam(queryParams, prop, attribute); AddQueryParam(queryParams, prop, attribute);
} }
} }
_queryParamsCache[type] = cachedParams;
} }
AddCustomQueryParams(queryParams); AddCustomQueryParams(queryParams);