removing scrobble PK on time, allowing duplicates

This commit is contained in:
andy 2022-02-20 21:54:01 +00:00
parent a10fc490bf
commit 042c2ab977
6 changed files with 595 additions and 18 deletions

View File

@ -77,7 +77,7 @@ namespace Selector
logger.LogDebug("Pulling currently stored scrobbles"); logger.LogDebug("Pulling currently stored scrobbles");
var currentScrobblesPulled = GetDbScrobbles(); var currentScrobbles = GetDbScrobbles();
await aggregateNetworkTask; await aggregateNetworkTask;
var scrobbles = runRequests.SelectMany(r => r.Scrobbles); var scrobbles = runRequests.SelectMany(r => r.Scrobbles);
@ -89,7 +89,7 @@ namespace Selector
RemoveNowPlaying(scrobbles.ToList()); RemoveNowPlaying(scrobbles.ToList());
var nativeScrobbles = scrobbles var nativeScrobbles = scrobbles
.DistinctBy(s => s.TimePlayed?.UtcDateTime) .DistinctBy(s => new { s.TimePlayed?.UtcDateTime, s.Name, s.ArtistName })
.Select(s => .Select(s =>
{ {
var nativeScrobble = (UserScrobble)s; var nativeScrobble = (UserScrobble)s;
@ -102,7 +102,7 @@ namespace Selector
logger.LogDebug("Identifying difference sets"); logger.LogDebug("Identifying difference sets");
var time = Stopwatch.StartNew(); var time = Stopwatch.StartNew();
(var toAdd, var toRemove) = ScrobbleMatcher.IdentifyDiffs(currentScrobblesPulled, nativeScrobbles); (var toAdd, var toRemove) = ScrobbleMatcher.IdentifyDiffs(currentScrobbles, nativeScrobbles);
time.Stop(); time.Stop();
logger.LogTrace("Finished diffing: {0:n}ms", time.ElapsedMilliseconds); logger.LogTrace("Finished diffing: {0:n}ms", time.ElapsedMilliseconds);

View File

@ -55,7 +55,6 @@ namespace Selector.Model
.WithMany(u => u.Watchers) .WithMany(u => u.Watchers)
.HasForeignKey(w => w.UserId); .HasForeignKey(w => w.UserId);
modelBuilder.Entity<UserScrobble>().HasKey(s => new { s.UserId, s.Timestamp });
modelBuilder.Entity<UserScrobble>() modelBuilder.Entity<UserScrobble>()
.HasOne(w => w.User) .HasOne(w => w.User)
.WithMany(u => u.Scrobbles) .WithMany(u => u.Scrobbles)

View File

@ -0,0 +1,461 @@
// <auto-generated />
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
using Selector.Model;
#nullable disable
namespace Selector.Model.Migrations
{
[DbContext(typeof(ApplicationDbContext))]
[Migration("20220220213329_scrobble_int_id")]
partial class scrobble_int_id
{
protected override void BuildTargetModel(ModelBuilder modelBuilder)
{
#pragma warning disable 612, 618
modelBuilder
.HasAnnotation("Npgsql:CollationDefinition:case_insensitive", "en-u-ks-primary,en-u-ks-primary,icu,False")
.HasAnnotation("ProductVersion", "6.0.2")
.HasAnnotation("Relational:MaxIdentifierLength", 63);
NpgsqlModelBuilderExtensions.UseIdentityByDefaultColumns(modelBuilder);
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityRole", b =>
{
b.Property<string>("Id")
.HasColumnType("text");
b.Property<string>("ConcurrencyStamp")
.IsConcurrencyToken()
.HasColumnType("text");
b.Property<string>("Name")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.Property<string>("NormalizedName")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.HasKey("Id");
b.HasIndex("NormalizedName")
.IsUnique()
.HasDatabaseName("RoleNameIndex");
b.ToTable("AspNetRoles", (string)null);
b.HasData(
new
{
Id = "00c64c0a-3387-4933-9575-83443fa9092b",
ConcurrencyStamp = "765f8993-a743-496b-8c8a-e43f532ac862",
Name = "Admin",
NormalizedName = "ADMIN"
});
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityRoleClaim<string>", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("ClaimType")
.HasColumnType("text");
b.Property<string>("ClaimValue")
.HasColumnType("text");
b.Property<string>("RoleId")
.IsRequired()
.HasColumnType("text");
b.HasKey("Id");
b.HasIndex("RoleId");
b.ToTable("AspNetRoleClaims", (string)null);
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserClaim<string>", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("ClaimType")
.HasColumnType("text");
b.Property<string>("ClaimValue")
.HasColumnType("text");
b.Property<string>("UserId")
.IsRequired()
.HasColumnType("text");
b.HasKey("Id");
b.HasIndex("UserId");
b.ToTable("AspNetUserClaims", (string)null);
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserLogin<string>", b =>
{
b.Property<string>("LoginProvider")
.HasColumnType("text");
b.Property<string>("ProviderKey")
.HasColumnType("text");
b.Property<string>("ProviderDisplayName")
.HasColumnType("text");
b.Property<string>("UserId")
.IsRequired()
.HasColumnType("text");
b.HasKey("LoginProvider", "ProviderKey");
b.HasIndex("UserId");
b.ToTable("AspNetUserLogins", (string)null);
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserRole<string>", b =>
{
b.Property<string>("UserId")
.HasColumnType("text");
b.Property<string>("RoleId")
.HasColumnType("text");
b.HasKey("UserId", "RoleId");
b.HasIndex("RoleId");
b.ToTable("AspNetUserRoles", (string)null);
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserToken<string>", b =>
{
b.Property<string>("UserId")
.HasColumnType("text");
b.Property<string>("LoginProvider")
.HasColumnType("text");
b.Property<string>("Name")
.HasColumnType("text");
b.Property<string>("Value")
.HasColumnType("text");
b.HasKey("UserId", "LoginProvider", "Name");
b.ToTable("AspNetUserTokens", (string)null);
});
modelBuilder.Entity("Selector.Model.AlbumLastfmSpotifyMapping", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("LastfmAlbumName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("LastfmArtistName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("SpotifyUri")
.HasColumnType("text");
b.HasKey("Id");
b.ToTable("AlbumMapping");
});
modelBuilder.Entity("Selector.Model.ApplicationUser", b =>
{
b.Property<string>("Id")
.HasColumnType("text");
b.Property<int>("AccessFailedCount")
.HasColumnType("integer");
b.Property<string>("ConcurrencyStamp")
.IsConcurrencyToken()
.HasColumnType("text");
b.Property<string>("Email")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.Property<bool>("EmailConfirmed")
.HasColumnType("boolean");
b.Property<string>("LastFmUsername")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<bool>("LockoutEnabled")
.HasColumnType("boolean");
b.Property<DateTimeOffset?>("LockoutEnd")
.HasColumnType("timestamp with time zone");
b.Property<string>("NormalizedEmail")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.Property<string>("NormalizedUserName")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.Property<string>("PasswordHash")
.HasColumnType("text");
b.Property<string>("PhoneNumber")
.HasColumnType("text");
b.Property<bool>("PhoneNumberConfirmed")
.HasColumnType("boolean");
b.Property<bool>("SaveScrobbles")
.HasColumnType("boolean");
b.Property<string>("SecurityStamp")
.HasColumnType("text");
b.Property<string>("SpotifyAccessToken")
.HasColumnType("text");
b.Property<bool>("SpotifyIsLinked")
.HasColumnType("boolean");
b.Property<DateTime>("SpotifyLastRefresh")
.HasColumnType("timestamp with time zone");
b.Property<string>("SpotifyRefreshToken")
.HasColumnType("text");
b.Property<int>("SpotifyTokenExpiry")
.HasColumnType("integer");
b.Property<bool>("TwoFactorEnabled")
.HasColumnType("boolean");
b.Property<string>("UserName")
.HasMaxLength(256)
.HasColumnType("character varying(256)");
b.HasKey("Id");
b.HasIndex("NormalizedEmail")
.HasDatabaseName("EmailIndex");
b.HasIndex("NormalizedUserName")
.IsUnique()
.HasDatabaseName("UserNameIndex");
b.ToTable("AspNetUsers", (string)null);
});
modelBuilder.Entity("Selector.Model.ArtistLastfmSpotifyMapping", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("LastfmArtistName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("SpotifyUri")
.HasColumnType("text");
b.HasKey("Id");
b.ToTable("ArtistMapping");
});
modelBuilder.Entity("Selector.Model.TrackLastfmSpotifyMapping", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("LastfmArtistName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("LastfmTrackName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("SpotifyUri")
.HasColumnType("text");
b.HasKey("Id");
b.ToTable("TrackMapping");
});
modelBuilder.Entity("Selector.Model.UserScrobble", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<string>("AlbumArtistName")
.HasColumnType("text");
b.Property<string>("AlbumName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("ArtistName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<DateTime>("Timestamp")
.HasColumnType("timestamp with time zone");
b.Property<string>("TrackName")
.HasColumnType("text")
.UseCollation("case_insensitive");
b.Property<string>("UserId")
.HasColumnType("text");
b.HasKey("Id");
b.HasIndex("UserId");
b.ToTable("Scrobble");
});
modelBuilder.Entity("Selector.Model.Watcher", b =>
{
b.Property<int>("Id")
.ValueGeneratedOnAdd()
.HasColumnType("integer");
NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
b.Property<int>("Type")
.HasColumnType("integer");
b.Property<string>("UserId")
.IsRequired()
.HasColumnType("text");
b.HasKey("Id");
b.HasIndex("UserId");
b.ToTable("Watcher");
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityRoleClaim<string>", b =>
{
b.HasOne("Microsoft.AspNetCore.Identity.IdentityRole", null)
.WithMany()
.HasForeignKey("RoleId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserClaim<string>", b =>
{
b.HasOne("Selector.Model.ApplicationUser", null)
.WithMany()
.HasForeignKey("UserId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserLogin<string>", b =>
{
b.HasOne("Selector.Model.ApplicationUser", null)
.WithMany()
.HasForeignKey("UserId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserRole<string>", b =>
{
b.HasOne("Microsoft.AspNetCore.Identity.IdentityRole", null)
.WithMany()
.HasForeignKey("RoleId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
b.HasOne("Selector.Model.ApplicationUser", null)
.WithMany()
.HasForeignKey("UserId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
});
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityUserToken<string>", b =>
{
b.HasOne("Selector.Model.ApplicationUser", null)
.WithMany()
.HasForeignKey("UserId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
});
modelBuilder.Entity("Selector.Model.UserScrobble", b =>
{
b.HasOne("Selector.Model.ApplicationUser", "User")
.WithMany("Scrobbles")
.HasForeignKey("UserId");
b.Navigation("User");
});
modelBuilder.Entity("Selector.Model.Watcher", b =>
{
b.HasOne("Selector.Model.ApplicationUser", "User")
.WithMany("Watchers")
.HasForeignKey("UserId")
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
b.Navigation("User");
});
modelBuilder.Entity("Selector.Model.ApplicationUser", b =>
{
b.Navigation("Scrobbles");
b.Navigation("Watchers");
});
#pragma warning restore 612, 618
}
}
}

View File

@ -0,0 +1,110 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
#nullable disable
namespace Selector.Model.Migrations
{
public partial class scrobble_int_id : Migration
{
protected override void Up(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropForeignKey(
name: "FK_Scrobble_AspNetUsers_UserId",
table: "Scrobble");
migrationBuilder.DropPrimaryKey(
name: "PK_Scrobble",
table: "Scrobble");
migrationBuilder.AlterColumn<string>(
name: "UserId",
table: "Scrobble",
type: "text",
nullable: true,
oldClrType: typeof(string),
oldType: "text");
migrationBuilder.AddColumn<int>(
name: "Id",
table: "Scrobble",
type: "integer",
nullable: false,
defaultValue: 0)
.Annotation("Npgsql:ValueGenerationStrategy", NpgsqlValueGenerationStrategy.IdentityByDefaultColumn);
migrationBuilder.AddPrimaryKey(
name: "PK_Scrobble",
table: "Scrobble",
column: "Id");
migrationBuilder.UpdateData(
table: "AspNetRoles",
keyColumn: "Id",
keyValue: "00c64c0a-3387-4933-9575-83443fa9092b",
column: "ConcurrencyStamp",
value: "765f8993-a743-496b-8c8a-e43f532ac862");
migrationBuilder.CreateIndex(
name: "IX_Scrobble_UserId",
table: "Scrobble",
column: "UserId");
migrationBuilder.AddForeignKey(
name: "FK_Scrobble_AspNetUsers_UserId",
table: "Scrobble",
column: "UserId",
principalTable: "AspNetUsers",
principalColumn: "Id");
}
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropForeignKey(
name: "FK_Scrobble_AspNetUsers_UserId",
table: "Scrobble");
migrationBuilder.DropPrimaryKey(
name: "PK_Scrobble",
table: "Scrobble");
migrationBuilder.DropIndex(
name: "IX_Scrobble_UserId",
table: "Scrobble");
migrationBuilder.DropColumn(
name: "Id",
table: "Scrobble");
migrationBuilder.AlterColumn<string>(
name: "UserId",
table: "Scrobble",
type: "text",
nullable: false,
defaultValue: "",
oldClrType: typeof(string),
oldType: "text",
oldNullable: true);
migrationBuilder.AddPrimaryKey(
name: "PK_Scrobble",
table: "Scrobble",
columns: new[] { "UserId", "Timestamp" });
migrationBuilder.UpdateData(
table: "AspNetRoles",
keyColumn: "Id",
keyValue: "00c64c0a-3387-4933-9575-83443fa9092b",
column: "ConcurrencyStamp",
value: "b91c880d-e280-4a17-a528-d34fdc35f291");
migrationBuilder.AddForeignKey(
name: "FK_Scrobble_AspNetUsers_UserId",
table: "Scrobble",
column: "UserId",
principalTable: "AspNetUsers",
principalColumn: "Id",
onDelete: ReferentialAction.Cascade);
}
}
}

View File

@ -52,7 +52,7 @@ namespace Selector.Model.Migrations
new new
{ {
Id = "00c64c0a-3387-4933-9575-83443fa9092b", Id = "00c64c0a-3387-4933-9575-83443fa9092b",
ConcurrencyStamp = "b91c880d-e280-4a17-a528-d34fdc35f291", ConcurrencyStamp = "765f8993-a743-496b-8c8a-e43f532ac862",
Name = "Admin", Name = "Admin",
NormalizedName = "ADMIN" NormalizedName = "ADMIN"
}); });
@ -185,7 +185,7 @@ namespace Selector.Model.Migrations
b.HasKey("Id"); b.HasKey("Id");
b.ToTable("AlbumMapping"); b.ToTable("AlbumMapping", (string)null);
}); });
modelBuilder.Entity("Selector.Model.ApplicationUser", b => modelBuilder.Entity("Selector.Model.ApplicationUser", b =>
@ -291,7 +291,7 @@ namespace Selector.Model.Migrations
b.HasKey("Id"); b.HasKey("Id");
b.ToTable("ArtistMapping"); b.ToTable("ArtistMapping", (string)null);
}); });
modelBuilder.Entity("Selector.Model.TrackLastfmSpotifyMapping", b => modelBuilder.Entity("Selector.Model.TrackLastfmSpotifyMapping", b =>
@ -315,16 +315,16 @@ namespace Selector.Model.Migrations
b.HasKey("Id"); b.HasKey("Id");
b.ToTable("TrackMapping"); b.ToTable("TrackMapping", (string)null);
}); });
modelBuilder.Entity("Selector.Model.UserScrobble", b => modelBuilder.Entity("Selector.Model.UserScrobble", b =>
{ {
b.Property<string>("UserId") b.Property<int>("Id")
.HasColumnType("text"); .ValueGeneratedOnAdd()
.HasColumnType("integer");
b.Property<DateTime>("Timestamp") NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
.HasColumnType("timestamp with time zone");
b.Property<string>("AlbumArtistName") b.Property<string>("AlbumArtistName")
.HasColumnType("text"); .HasColumnType("text");
@ -337,13 +337,21 @@ namespace Selector.Model.Migrations
.HasColumnType("text") .HasColumnType("text")
.UseCollation("case_insensitive"); .UseCollation("case_insensitive");
b.Property<DateTime>("Timestamp")
.HasColumnType("timestamp with time zone");
b.Property<string>("TrackName") b.Property<string>("TrackName")
.HasColumnType("text") .HasColumnType("text")
.UseCollation("case_insensitive"); .UseCollation("case_insensitive");
b.HasKey("UserId", "Timestamp"); b.Property<string>("UserId")
.HasColumnType("text");
b.ToTable("Scrobble"); b.HasKey("Id");
b.HasIndex("UserId");
b.ToTable("Scrobble", (string)null);
}); });
modelBuilder.Entity("Selector.Model.Watcher", b => modelBuilder.Entity("Selector.Model.Watcher", b =>
@ -365,7 +373,7 @@ namespace Selector.Model.Migrations
b.HasIndex("UserId"); b.HasIndex("UserId");
b.ToTable("Watcher"); b.ToTable("Watcher", (string)null);
}); });
modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityRoleClaim<string>", b => modelBuilder.Entity("Microsoft.AspNetCore.Identity.IdentityRoleClaim<string>", b =>
@ -423,9 +431,7 @@ namespace Selector.Model.Migrations
{ {
b.HasOne("Selector.Model.ApplicationUser", "User") b.HasOne("Selector.Model.ApplicationUser", "User")
.WithMany("Scrobbles") .WithMany("Scrobbles")
.HasForeignKey("UserId") .HasForeignKey("UserId");
.OnDelete(DeleteBehavior.Cascade)
.IsRequired();
b.Navigation("User"); b.Navigation("User");
}); });

View File

@ -4,6 +4,7 @@ namespace Selector.Model
{ {
public class UserScrobble: Scrobble public class UserScrobble: Scrobble
{ {
public int Id { get; set; }
public string UserId { get; set; } public string UserId { get; set; }
public ApplicationUser User { get; set; } public ApplicationUser User { get; set; }