Add small integration test for Lastfm.User.GetInfoAsync()

- proves #100 is fixed, can add checks for the other fields later
This commit is contained in:
Rikki Tooley 2017-04-16 19:03:35 +01:00
parent c7a36350b7
commit 894d81c740
4 changed files with 26 additions and 8 deletions

View File

@ -0,0 +1,22 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using NUnit.Framework;
namespace IF.Lastfm.Core.Tests.Integration.Commands
{
public class UserGetInfoTests : CommandIntegrationTestsBase
{
[Test]
public async Task GetInfo_Success()
{
var response = await Lastfm.User.GetInfoAsync(INTEGRATION_TEST_USER);
var user = response.Content;
Assert.AreEqual(INTEGRATION_TEST_USER, user.Name);
Assert.IsTrue(user.Playcount > 0);
}
}
}

View File

@ -73,6 +73,7 @@
<Compile Include="Commands\CommandIntegrationTestsBase.cs" />
<Compile Include="Commands\TrackScrobbleCommandTests.cs" />
<Compile Include="Commands\TrackUpdateNowPlayingCommandTests.cs" />
<Compile Include="Commands\UserGetInfoTests.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>

View File

@ -29,8 +29,7 @@ public override async Task<LastResponse<LastUser>> HandleResponse(HttpResponseMe
{
var json = await response.Content.ReadAsStringAsync();
LastResponseStatus status;
if (LastFm.IsResponseValid(json, out status) && response.IsSuccessStatusCode)
if (LastFm.IsResponseValid(json, out LastResponseStatus status) && response.IsSuccessStatusCode)
{
var jtoken = JsonConvert.DeserializeObject<JToken>(json);
var userToken = jtoken.SelectToken("user");

View File

@ -7,8 +7,6 @@ namespace IF.Lastfm.Core.Objects
{
public class LastUser : ILastfmObject
{
#region Properties
public string Name { get; private set; }
public string FullName { get; private set; }
public LastImageSet Avatar { get; private set; }
@ -23,8 +21,6 @@ public class LastUser : ILastfmObject
public int Bootstrap { get; private set; }
public string Type { get; private set; }
#endregion
/// <summary>
/// Parses the given <paramref name="token"/> to a
/// <see cref="LastUser"/>.
@ -33,7 +29,7 @@ public class LastUser : ILastfmObject
/// <returns>Parsed LastUser.</returns>
internal static LastUser ParseJToken(JToken token)
{
var u = new LastUser()
var u = new LastUser
{
Name = token.Value<string>("name"),
FullName = token.Value<string>("realname"),
@ -43,7 +39,7 @@ internal static LastUser ParseJToken(JToken token)
Playlists = token.Value<int>("playlists"),
Gender = ParseGender(token.Value<string>("gender")),
IsSubscriber = Convert.ToBoolean(token.Value<int>("subscriber")),
TimeRegistered = token.SelectToken("registered").Value<double>("unixtime").FromUnixTime().DateTime,
TimeRegistered = token.Value<double>("registered.unixtime").FromUnixTime().DateTime,
Bootstrap = token.Value<int>("bootstrap"),
Type = token.Value<string>("type")
};