From 4e2b7b02354f87f5b820f94a7a53070a75a88f51 Mon Sep 17 00:00:00 2001 From: Rikki Tooley Date: Wed, 24 Jul 2013 00:07:19 +0100 Subject: [PATCH] Removed methods using mbids. They weren't implemented anyway and last.fm doesn't use them reliably (see http://www.last.fm/group/Last.fm+Web+Services/forum/21604/_/2210879) --- IF.Lastfm.Core/Api/AlbumApi.cs | 50 -------------------------------- IF.Lastfm.Core/Api/ArtistApi.cs | 45 ---------------------------- IF.Lastfm.Core/Api/IAlbumApi.cs | 38 +----------------------- IF.Lastfm.Core/Api/IArtistApi.cs | 33 --------------------- IF.Lastfm.Core/Api/ITrackApi.cs | 5 ---- IF.Lastfm.Core/Api/TrackApi.cs | 10 ------- 6 files changed, 1 insertion(+), 180 deletions(-) diff --git a/IF.Lastfm.Core/Api/AlbumApi.cs b/IF.Lastfm.Core/Api/AlbumApi.cs index 40f1816..56519e5 100644 --- a/IF.Lastfm.Core/Api/AlbumApi.cs +++ b/IF.Lastfm.Core/Api/AlbumApi.cs @@ -22,8 +22,6 @@ public AlbumApi(IAuth auth) Auth = auth; } - #region album.getInfo - public async Task> GetAlbumInfoAsync(string artistname, string albumname, bool autocorrect = false) { var command = new GetAlbumInfoCommand(Auth, artistname, albumname) @@ -34,78 +32,30 @@ public async Task> GetAlbumInfoAsync(string artistname, stri return await command.ExecuteAsync(); } - public Task> GetAlbumInfoWithMbidAsync(string mbid, bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion - - #region album.getBuylinks - public Task> GetBuyLinksForAlbumAsync(string artist, string album, CountryCode country, bool autocorrect = false) { throw new NotImplementedException(); } - public Task> GetBuyLinksForAlbumWithMbidAsync(string mbid, CountryCode country, bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion - - #region album.getShouts - public Task> GetShoutsForAlbumAsync(string artist, string album, bool autocorrect = false, int page = 1, int itemsPerPage = LastFm.DefaultPageLength) { throw new NotImplementedException(); } - public Task> GetShoutsForAlbumWithMbidAsync(string mbid, bool autocorrect = false, int page = 1, - int itemsPerPage = LastFm.DefaultPageLength) - { - throw new NotImplementedException(); - } - - #endregion - - #region album.getTags - public Task> GetUserTagsForAlbumAsync(string artist, string album, string username, bool autocorrect = false) { throw new NotImplementedException(); } - public Task> GetUserTagsForAlbumWithMbidAsync(string mbid, string username, bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion - - #region album.getTopTags - public Task> GetTopTagsForAlbumAsync(string artist, string album, bool autocorrect = false) { throw new NotImplementedException(); } - public Task> GetTopTagsForAlbumWithMbidAsync(string mbid, bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion - - #region album.search - public Task> SearchForAlbumAsync(string album, int page = 1, int itemsPerPage = LastFm.DefaultPageLength) { throw new NotImplementedException(); } - - #endregion } } \ No newline at end of file diff --git a/IF.Lastfm.Core/Api/ArtistApi.cs b/IF.Lastfm.Core/Api/ArtistApi.cs index 46b3cd4..e16d55e 100644 --- a/IF.Lastfm.Core/Api/ArtistApi.cs +++ b/IF.Lastfm.Core/Api/ArtistApi.cs @@ -15,8 +15,6 @@ public ArtistApi(IAuth auth) Auth = auth; } - #region artist.getInfo - public async Task> GetArtistInfoAsync(string artist, string bioLang = LastFm.DefaultLanguageCode, bool autocorrect = false) @@ -30,17 +28,6 @@ public async Task> GetArtistInfoAsync(string artist, return await command.ExecuteAsync(); } - public async Task> GetArtistInfoWithMbidAsync(string mbid, - string bioLang = LastFm.DefaultLanguageCode, - bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion - - #region artist.getTopAlbums - public async Task> GetTopAlbumsForArtistAsync(string artist, bool autocorrect = false, int page = 1, @@ -49,18 +36,6 @@ public async Task> GetTopAlbumsForArtistAsync(string artist, throw new NotImplementedException(); } - public async Task> GetTopAlbumsForArtistWithMbidAsync(string mbid, - bool autocorrect = false, - int page = 1, - int itemsPerPage = LastFm.DefaultPageLength) - { - throw new NotImplementedException(); - } - - #endregion - - #region artist.getTags - public async Task> GetUserTagsForArtistAsync(string artist, string username, bool autocorrect = false, @@ -70,29 +45,9 @@ public async Task> GetUserTagsForArtistAsync(string artist, throw new NotImplementedException(); } - public async Task> GetUserTagsForArtistWithMbidAsync(string mbid, - string username, - bool autocorrect = false, - int page = 1, - int itemsPerPage = LastFm.DefaultPageLength) - { - throw new NotImplementedException(); - } - - #endregion - - #region artist.getTopTags - public async Task> GetTopTagsForArtistAsync(string artist, bool autocorrect = false) { throw new NotImplementedException(); } - - public async Task> GetTopTagsForArtistWithMbidAsync(string mbid, bool autocorrect = false) - { - throw new NotImplementedException(); - } - - #endregion } } \ No newline at end of file diff --git a/IF.Lastfm.Core/Api/IAlbumApi.cs b/IF.Lastfm.Core/Api/IAlbumApi.cs index 67f5e35..fe1a794 100644 --- a/IF.Lastfm.Core/Api/IAlbumApi.cs +++ b/IF.Lastfm.Core/Api/IAlbumApi.cs @@ -10,59 +10,23 @@ public interface IAlbumApi { IAuth Auth { get; } - #region album.getInfo - Task> GetAlbumInfoAsync(string artist, string album, bool autocorrect = false); - Task> GetAlbumInfoWithMbidAsync(string mbid, bool autocorrect = false); - #endregion - - #region album.getBuylinks - Task> GetBuyLinksForAlbumAsync(string artist, string album, CountryCode country, bool autocorrect = false); - Task> GetBuyLinksForAlbumWithMbidAsync(string mbid, - CountryCode country, - bool autocorrect = false); - - #endregion - - #region album.getShouts - Task> GetShoutsForAlbumAsync(string artist, string album, bool autocorrect = false, int page = 1, int itemsPerPage = LastFm.DefaultPageLength); - - Task> GetShoutsForAlbumWithMbidAsync(string mbid, - bool autocorrect = false, - int page = 1, - int itemsPerPage = LastFm.DefaultPageLength); - - #endregion - - #region album.getTags - + Task> GetUserTagsForAlbumAsync(string artist, string album, string username, bool autocorrect = false); - Task> GetUserTagsForAlbumWithMbidAsync(string mbid, string username, bool autocorrect = false); - - #endregion - - #region album.getTopTags Task> GetTopTagsForAlbumAsync(string artist, string album, bool autocorrect = false); - Task> GetTopTagsForAlbumWithMbidAsync(string mbid, bool autocorrect = false); - - #endregion - - #region album.search Task> SearchForAlbumAsync(string album, int page = 1, int itemsPerPage = LastFm.DefaultPageLength); - - #endregion } } \ No newline at end of file diff --git a/IF.Lastfm.Core/Api/IArtistApi.cs b/IF.Lastfm.Core/Api/IArtistApi.cs index 3b7e68d..357dc03 100644 --- a/IF.Lastfm.Core/Api/IArtistApi.cs +++ b/IF.Lastfm.Core/Api/IArtistApi.cs @@ -12,53 +12,20 @@ public interface IArtistApi { IAuth Auth { get; } - #region artist.getInfo - Task> GetArtistInfoAsync(string artist, string bioLang = LastFm.DefaultLanguageCode, bool autocorrect = false); - Task> GetArtistInfoWithMbidAsync(string mbid, string bioLang = LastFm.DefaultLanguageCode, - bool autocorrect = false); - - #endregion - - #region artist.getTopAlbums - Task> GetTopAlbumsForArtistAsync(string artist, bool autocorrect = false, int page = 1, int itemsPerPage = LastFm.DefaultPageLength); - Task> GetTopAlbumsForArtistWithMbidAsync(string mbid, - bool autocorrect = false, - int page = 1, - int itemsPerPage = LastFm.DefaultPageLength); - - #endregion - - #region artist.getTags - Task> GetUserTagsForArtistAsync(string artist, string username, bool autocorrect = false, int page = 1, int itemsPerPage = LastFm.DefaultPageLength); - Task> GetUserTagsForArtistWithMbidAsync(string mbid, - string username, - bool autocorrect = false, - int page = 1, - int itemsPerPage = LastFm.DefaultPageLength); - - #endregion - - #region artist.getTopTags - Task> GetTopTagsForArtistAsync(string artist, bool autocorrect = false); - - Task> GetTopTagsForArtistWithMbidAsync(string mbid, bool autocorrect = false); - - #endregion - } } diff --git a/IF.Lastfm.Core/Api/ITrackApi.cs b/IF.Lastfm.Core/Api/ITrackApi.cs index 03e9a31..0440d3a 100644 --- a/IF.Lastfm.Core/Api/ITrackApi.cs +++ b/IF.Lastfm.Core/Api/ITrackApi.cs @@ -16,11 +16,6 @@ Task> GetShoutsForTrackAsync(string trackname, string artist int page = 0, int count = LastFm.DefaultPageLength); - Task> GetShoutsForTrackWithMbidAsync(string mbid, - int page = 0, - int count = LastFm.DefaultPageLength); - Task> GetInfoAsync(string trackname, string artistname, string username = ""); - Task> GetInfoWithMbidAsynnc(string mbid, string username = ""); } } \ No newline at end of file diff --git a/IF.Lastfm.Core/Api/TrackApi.cs b/IF.Lastfm.Core/Api/TrackApi.cs index 8e5345b..a2326db 100644 --- a/IF.Lastfm.Core/Api/TrackApi.cs +++ b/IF.Lastfm.Core/Api/TrackApi.cs @@ -70,11 +70,6 @@ public async Task> GetShoutsForTrackAsync(string trackname, return await command.ExecuteAsync(); } - public Task> GetShoutsForTrackWithMbidAsync(string mbid, int page = 0, int count = LastFm.DefaultPageLength) - { - throw new NotImplementedException(); - } - public async Task> GetInfoAsync(string trackname, string artistname, string username = "") { var command = new GetTrackInfoCommand(Auth, trackname, artistname) @@ -84,10 +79,5 @@ public async Task> GetInfoAsync(string trackname, string art return await command.ExecuteAsync(); } - - public Task> GetInfoWithMbidAsynnc(string mbid, string username = "") - { - throw new NotImplementedException(); - } } } \ No newline at end of file